Skip to content

chore: Clean up entity key serialization#3199

Merged
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
felixwang9817:entity_key_serialization
Sep 8, 2022
Merged

chore: Clean up entity key serialization#3199
feast-ci-bot merged 3 commits into
feast-dev:masterfrom
felixwang9817:entity_key_serialization

Conversation

@felixwang9817

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

@kevjumba kevjumba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

@kevjumba kevjumba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Sep 8, 2022
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot merged commit 782c759 into feast-dev:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants