Skip to content

fix: Fix materialization when running on Spark cluster. #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Sep 9, 2022
Merged

fix: Fix materialization when running on Spark cluster. #3166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a802cfe
Fix materialization when running on Spark cluster.
ckarwicki Sep 1, 2022
21fa5bc
Fix linter.
ckarwicki Sep 1, 2022
b9d36c1
Fix linter.
ckarwicki Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,7 @@ def _to_df_internal(self) -> pd.DataFrame:

def _to_arrow_internal(self) -> pyarrow.Table:
"""Return dataset as pyarrow Table synchronously"""

# write to temp parquet and then load it as pyarrow table from disk
with tempfile.TemporaryDirectory() as temp_dir:
self.to_spark_df().write.parquet(temp_dir, mode="overwrite")
return pq.read_table(temp_dir)
return pyarrow.Table.from_pandas(self._to_df_internal())

def persist(self, storage: SavedDatasetStorage, allow_overwrite: bool = False):
"""
Expand Down