ci: Fix go unit tests failure #3078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Chiao <danny@tecton.ai>
achals
approved these changes
Aug 12, 2022
Makefile
Outdated
| # Needs feast package to setup the feature store | ||
| # CGO flag is due to this issue: https://github.com/golang/go/wiki/InvalidFlag | ||
| test-go: compile-protos-go compile-go-lib install-feast-ci-locally | ||
| test-go: compile-protos-python compile-protos-go compile-go-lib install-feast-ci-locally |
Codecov Report
@@ Coverage Diff @@
## master #3078 +/- ##
==========================================
+ Coverage 67.43% 75.93% +8.49%
==========================================
Files 169 203 +34
Lines 14936 16839 +1903
==========================================
+ Hits 10072 12786 +2714
+ Misses 4864 4053 -811
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
franciscojavierarceo
pushed a commit
to franciscojavierarceo/feast
that referenced
this pull request
Aug 13, 2022
* ci: Fix go unit tests failure Signed-off-by: Danny Chiao <danny@tecton.ai> * Temporary fix? Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Kevin Zhang <kzhang@tecton.ai> Co-authored-by: Kevin Zhang <kzhang@tecton.ai> Signed-off-by: Francisco Javier Arceo <arceofrancisco@gmail.com>
adchia
added a commit
that referenced
this pull request
Aug 15, 2022
* ci: Fix go unit tests failure Signed-off-by: Danny Chiao <danny@tecton.ai> * Temporary fix? Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Kevin Zhang <kzhang@tecton.ai> Co-authored-by: Kevin Zhang <kzhang@tecton.ai>
adchia
added a commit
that referenced
this pull request
Aug 15, 2022
* ci: Fix go unit tests failure Signed-off-by: Danny Chiao <danny@tecton.ai> * Temporary fix? Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Fix Signed-off-by: Kevin Zhang <kzhang@tecton.ai> Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Kevin Zhang <kzhang@tecton.ai> Co-authored-by: Kevin Zhang <kzhang@tecton.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Unclear why tests passed before, but the Go unit tests run the Feast Python CLI, which relies on Python protos being built. The original
make test-gocommand does not build those Python protos.Which issue(s) this PR fixes:
Fixes #