Skip to content

Conversation

@achals
Copy link
Member

@achals achals commented Aug 10, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #3061 (735bee2) into master (e78d1d7) will increase coverage by 8.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3061      +/-   ##
==========================================
+ Coverage   67.59%   75.75%   +8.15%     
==========================================
  Files         168      202      +34     
  Lines       14712    16780    +2068     
==========================================
+ Hits         9944    12711    +2767     
+ Misses       4768     4069     -699     
Flag Coverage Δ
integrationtests 67.08% <ø> (-0.51%) ⬇️
unittests 58.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/utils/aws_utils.py 62.85% <0.00%> (-14.03%) ⬇️
sdk/python/feast/type_map.py 61.72% <0.00%> (-1.55%) ⬇️
sdk/python/feast/infra/provider.py 77.94% <0.00%> (ø)
sdk/python/feast/infra/utils/snowflake_utils.py 77.77% <0.00%> (ø)
...tion/feature_repos/universal/online_store/hbase.py 50.00% <0.00%> (ø)
...s/contrib/spark_offline_store/tests/data_source.py 40.42% <0.00%> (ø)
.../feature_repos/universal/online_store/cassandra.py 42.85% <0.00%> (ø)
...b/cassandra_online_store/cassandra_online_store.py 2.63% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...ores/contrib/athena_offline_store/athena_source.py 45.61% <0.00%> (ø)
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@feast-ci-bot feast-ci-bot merged commit 5cebee8 into feast-dev:master Aug 10, 2022
adchia pushed a commit that referenced this pull request Aug 10, 2022
* docs: Merge the feature repo docs pages

Signed-off-by: Achal Shah <achals@gmail.com>

* delete

Signed-off-by: Achal Shah <achals@gmail.com>

Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals deleted the achal/feature-repo-docs branch August 10, 2022 22:20
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Aug 13, 2022
* docs: Merge the feature repo docs pages

Signed-off-by: Achal Shah <achals@gmail.com>

* delete

Signed-off-by: Achal Shah <achals@gmail.com>

Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Francisco Javier Arceo <arceofrancisco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants