Skip to content

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Aug 10, 2022

Signed-off-by: Danny Chiao danny@tecton.ai

What this PR does / why we need it:
There are some missing pieces of the release notes. Also added more verification steps and documentation on how to maintain maintenance releases (older branches)
Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 10, 2022
@felixwang9817
Copy link
Collaborator

/lgtm

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 10, 2022
@felixwang9817
Copy link
Collaborator

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #3060 (a0b4432) into master (74c75f1) will increase coverage by 8.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3060      +/-   ##
==========================================
+ Coverage   67.23%   75.75%   +8.51%     
==========================================
  Files         169      202      +33     
  Lines       14920    16780    +1860     
==========================================
+ Hits        10031    12711    +2680     
+ Misses       4889     4069     -820     
Flag Coverage Δ
integrationtests 67.08% <ø> (-0.15%) ⬇️
unittests 58.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ores/contrib/trino_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...ffline_stores/contrib/spark_offline_store/spark.py 37.41% <0.00%> (ø)
...s/contrib/trino_offline_store/tests/data_source.py 17.64% <0.00%> (ø)
...offline_stores/contrib/trino_repo_configuration.py 20.00% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
...ffline_stores/contrib/athena_repo_configuration.py 50.00% <0.00%> (ø)
...hon/feast/infra/utils/postgres/connection_utils.py 48.00% <0.00%> (ø)
...s/contrib/postgres_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
.../contrib/athena_offline_store/tests/data_source.py 48.83% <0.00%> (ø)
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@feast-ci-bot feast-ci-bot merged commit 16923b4 into feast-dev:master Aug 10, 2022
adchia added a commit that referenced this pull request Aug 10, 2022
* docs: Improve release process notes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* more links

Signed-off-by: Danny Chiao <danny@tecton.ai>

* more links

Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Danny Chiao <danny@tecton.ai>
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Aug 13, 2022
* docs: Improve release process notes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* more links

Signed-off-by: Danny Chiao <danny@tecton.ai>

* more links

Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Francisco Javier Arceo <arceofrancisco@gmail.com>
adchia added a commit that referenced this pull request Aug 15, 2022
* docs: Improve release process notes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* more links

Signed-off-by: Danny Chiao <danny@tecton.ai>

* more links

Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the releaseProcessUpdate branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants