Skip to content

chore: Fix error where all calls register as test calls because typeguard imports unittest #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 2 commits into from
Aug 7, 2022
Merged

chore: Fix error where all calls register as test calls because typeguard imports unittest #3030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06a4bfd
chore: Fix error where all calls report is_test as true because typeg…
adchia Aug 7, 2022
113e892
fix
adchia Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/python/feast/usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

import requests

from feast import flags_helper
from feast.constants import DEFAULT_FEAST_USAGE_VALUE, FEAST_USAGE
from feast.version import get_version

Expand Down Expand Up @@ -172,7 +173,8 @@ def _export(event: typing.Dict[str, typing.Any]):


def _produce_event(ctx: UsageContext):
is_test = bool({"pytest", "unittest"} & sys.modules.keys())
# Cannot check for unittest because typeguard pulls in unittest
is_test = flags_helper.is_test() or bool({"pytest"} & sys.modules.keys())
event = {
"timestamp": datetime.utcnow().isoformat(),
"is_test": is_test,
Expand Down