Skip to content

Conversation

@kevjumba
Copy link
Collaborator

@kevjumba kevjumba commented Aug 5, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@kevjumba kevjumba changed the title chore: Maintainer docs chore: Add documentation for maintainer development Aug 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #3025 (326a377) into master (5fc73d5) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage   77.57%   77.38%   -0.19%     
==========================================
  Files         194      194              
  Lines       16272    16620     +348     
==========================================
+ Hits        12623    12862     +239     
- Misses       3649     3758     +109     
Flag Coverage Δ
integrationtests 67.57% <ø> (+0.21%) ⬆️
unittests 59.33% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 86.51% <ø> (ø)
.../feature_repos/universal/data_sources/snowflake.py 100.00% <ø> (ø)
sdk/python/feast/feature.py 46.34% <0.00%> (-21.96%) ⬇️
sdk/python/feast/feature_store.py 77.39% <0.00%> (-5.47%) ⬇️
sdk/python/feast/data_source.py 76.92% <0.00%> (-4.24%) ⬇️
sdk/python/feast/field.py 89.74% <0.00%> (-2.57%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
sdk/python/feast/stream_feature_view.py 92.92% <0.00%> (-0.47%) ⬇️
...thon/tests/unit/infra/test_inference_unit_tests.py 100.00% <0.00%> (ø)
...fline_store/test_universal_historical_retrieval.py 100.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit fe9a0bd into feast-dev:master Aug 6, 2022
adchia pushed a commit that referenced this pull request Aug 10, 2022
* Maintainer test docs

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Add links from contributing and development guide

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants