Skip to content

ci: Fix pip install issues from grpcio version mismatches#2984

Merged
kevjumba merged 3 commits into
feast-dev:masterfrom
adchia:fixCI
Jul 29, 2022
Merged

ci: Fix pip install issues from grpcio version mismatches#2984
kevjumba merged 3 commits into
feast-dev:masterfrom
adchia:fixCI

Conversation

@adchia

@adchia adchia commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This fixes an issue when running pip install -e ".[dev]":

Some build dependencies for file:///home/runner/work/feast/feast conflict with the backend dependencies: grpcio==1.48.0 is incompatible with grpcio==1.47.0.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter

codecov-commenter commented Jul 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2984 (7a1003a) into master (5edf4b0) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
- Coverage   77.69%   77.65%   -0.05%     
==========================================
  Files         186      186              
  Lines       16387    16387              
==========================================
- Hits        12732    12725       -7     
- Misses       3655     3662       +7     
Flag Coverage Δ
integrationtests 68.64% <ø> (-0.14%) ⬇️
unittests 58.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edf4b0...7a1003a. Read the comment docs.

adchia added 2 commits July 29, 2022 00:15
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>

@kevjumba kevjumba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevjumba kevjumba merged commit f2696e0 into feast-dev:master Jul 29, 2022
@adchia adchia deleted the fixCI branch August 5, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants