Skip to content

docs: Update intro documentation page #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feast-ci-bot merged 3 commits into from
Jul 29, 2022
Merged

docs: Update intro documentation page #2982

feast-ci-bot merged 3 commits into from
Jul 29, 2022

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Jul 28, 2022

What this PR does / why we need it:
This updates the intro Feast documentation page to clarify on:

  • What Feast is
  • What Feast doesn't fully do
  • Who Feast is built for
  • Example use cases

Which issue(s) this PR fixes:

Fixes #

@adchia adchia changed the title docs: update intro documentation page docs: Update intro documentation page Jul 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #2982 (4d8b2f3) into master (2680f7b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
- Coverage   77.82%   77.78%   -0.05%     
==========================================
  Files         192      192              
  Lines       16427    16427              
==========================================
- Hits        12784    12777       -7     
- Misses       3643     3650       +7
Flag Coverage Δ
integrationtests 67.87% <ø> (-0.15%) ⬇️
unittests 59.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/basic_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2680f7b...4d8b2f3. Read the comment docs.

kevjumba
kevjumba approved these changes Jul 29, 2022
View reviewed changes
achals
achals approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adchia added 3 commits July 29, 2022 17:13
@adchia
GitBook: [#3] docs: update intro documentation page
7a54227 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
update main README blurb
c236447 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
address comments
4d8b2f3 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label Jul 29, 2022
@kevjumba
Copy link
Collaborator

kevjumba commented Jul 29, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit 61a194c into feast-dev:master Jul 29, 2022
adchia added a commit that referenced this pull request Aug 1, 2022
@adchia
docs: Update intro documentation page (#2982)
39cd44e 
* GitBook: [#3] docs: update intro documentation page

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update main README blurb

Signed-off-by: Danny Chiao <danny@tecton.ai>

* address comments

Signed-off-by: Danny Chiao <danny@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

@kevjumba kevjumba kevjumba approved these changes

Assignees

@achals achals

@kevjumba kevjumba

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adchia @codecov-commenter @feast-ci-bot @kevjumba @achals