chore: Update helm chart name #2969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
changed the title
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
achals
approved these changes
Jul 25, 2022
Comment on lines
+51
to
+52
| RUN apt update && \ | ||
| apt install -y jq |
Collaborator
Author
There was a problem hiding this comment.
yes good call
Comment on lines
4
to
6
| name: {{ include "feast-python-server.name" . }} | ||
| labels: | ||
| {{- include "feast-python-server.labels" . | nindent 4 }} |
felixwang9817
changed the title
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2969 +/- ##
==========================================
- Coverage 77.65% 77.61% -0.05%
==========================================
Files 186 186
Lines 16354 16354
==========================================
- Hits 12700 12693 -7
- Misses 3654 3661 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adchia
pushed a commit
that referenced
this pull request
Aug 10, 2022
* Rename feast-python-server helm chart to feast-feature-server Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Switch example to Python 3.8 Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Update helm chart docs Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Change name Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Change references Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Change another reference Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Add arrow C++ library to example Dockerfile Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Note that I did not remove the existing
feast-python-serverhelm chart. Instead, I simply made a newfeast-feature-serverhelm chart that copiesfeast-python-server.Which issue(s) this PR fixes:
Fixes #