Skip to content

chore: Add separate go_feature_serving flag #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feast-ci-bot merged 1 commit into from
Jul 22, 2022
Merged

chore: Add separate go_feature_serving flag #2968

feast-ci-bot merged 1 commit into from
Jul 22, 2022

Conversation

@felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Jul 22, 2022 •
edited
Loading

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@felixwang9817
Add separate go_feature_serving flag to distinguish between Go feat…
2acdd57 
…ure serving and embedded Go code

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title chore: Add separate go_feature_serving flag to distinguish between Go feat… chore: Add separate go_feature_serving flag Jul 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022 •
edited
Loading

Codecov Report

Merging #2968 (2acdd57) into master (a36a695) will decrease coverage by 19.20%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           master    #2968       +/-   ##
===========================================
- Coverage   77.72%   58.52%   -19.21%     
===========================================
  Files         186      186               
  Lines       16347    16350        +3     
===========================================
- Hits        12706     9569     -3137     
- Misses       3641     6781     +3140
Flag Coverage Δ
integrationtests ?
unittests 58.52% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 39.60% <0.00%> (ø)
sdk/python/feast/feature_store.py 67.95% <0.00%> (-17.89%) ⬇️
...on/tests/integration/e2e/test_go_feature_server.py 34.30% <0.00%> (ø)
...ts/integration/feature_repos/repo_configuration.py 55.42% <ø> (-30.86%) ⬇️
sdk/python/feast/repo_config.py 76.53% <100.00%> (-12.18%) ⬇️
sdk/python/tests/conftest.py 67.76% <100.00%> (-9.87%) ⬇️
...tion/feature_repos/integration_test_repo_config.py 87.80% <100.00%> (ø)
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.36% <0.00%> (-76.64%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36a695...2acdd57. Read the comment docs.

@achals achals added the lgtm label Jul 22, 2022
achals
achals approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit aa2a86a into feast-dev:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @achals