Skip to content

Conversation

@felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 changed the title docs: Fix docs for Go feature retrieval docs: Fix docs for Go feature retrieval [WIP] Jul 21, 2022
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #2967 (eee076e) into master (aa2a86a) will decrease coverage by 19.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2967       +/-   ##
===========================================
- Coverage   77.65%   58.51%   -19.14%     
===========================================
  Files         186      186               
  Lines       16354    16354               
===========================================
- Hits        12700     9570     -3130     
- Misses       3654     6784     +3130     
Flag Coverage Δ
integrationtests ?
unittests 58.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.36% <0.00%> (-76.64%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 28.84% <0.00%> (-69.24%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-69.05%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/tests/utils/logged_features.py 32.65% <0.00%> (-67.35%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2a86a...eee076e. Read the comment docs.

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title docs: Fix docs for Go feature retrieval [WIP] docs: Fix docs for Go feature retrieval Jul 22, 2022
@kevjumba
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit a15fcb4 into feast-dev:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants