Skip to content

chore: Fix test asserts for offline store write and improve some errors #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feast-ci-bot merged 6 commits into from
Jul 22, 2022
Merged

chore: Fix test asserts for offline store write and improve some errors #2964

feast-ci-bot merged 6 commits into from
Jul 22, 2022

Conversation

@achals
Copy link
Member

@achals achals commented Jul 21, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals
chore: Fix test asserts for offline store write and improve some erro…
e430788 
…r messages

Signed-off-by: Achal Shah <achals@gmail.com>
felixwang9817
felixwang9817 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
wait for write to finish
f366050 
Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jul 21, 2022

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Jul 21, 2022
achals added 2 commits July 21, 2022 10:27
@achals
wait for write to finish
cf86cf7 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
detailed error messages
536bc76 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #2964 (45d2c03) into master (6d7b38a) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
- Coverage   77.72%   77.61%   -0.12%     
==========================================
  Files         186      186              
  Lines       16339    16348       +9     
==========================================
- Hits        12700    12689      -11     
- Misses       3639     3659      +20
Flag Coverage Δ
integrationtests 68.58% <100.00%> (-0.23%) ⬇️
unittests 58.51% <7.69%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 85.71% <ø> (-0.13%) ⬇️
sdk/python/feast/infra/offline_stores/bigquery.py 86.01% <ø> (-0.35%) ⬇️
sdk/python/feast/usage.py 91.53% <100.00%> (ø)
...ts/integration/offline_store/test_offline_write.py 100.00% <100.00%> (ø)
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/offline_store/test_feature_logging.py 95.45% <0.00%> (-4.55%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 96.82% <0.00%> (-2.39%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7b38a...45d2c03. Read the comment docs.

achals added 2 commits July 21, 2022 15:26
@achals
sort and reset index
7bb7aea 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
fix
45d2c03 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals added the lgtm label Jul 22, 2022
@feast-ci-bot feast-ci-bot merged commit a233d3f into feast-dev:master Jul 22, 2022
@achals achals deleted the achal/misc-bugfixes branch July 25, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @feast-ci-bot @codecov-commenter @felixwang9817