Skip to content

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Jul 20, 2022

What this PR does / why we need it:
This adds

  • More details on release process (including documentation updates / making a new branch for minor releases)
  • Clean up references to old architecture
  • Cleaning up confusing roadmap items and adding pointers to Go feature serving
  • Adding DataHub integration as part of functionality

Which issue(s) this PR fixes:

Fixes #

adchia added 2 commits July 20, 2022 14:15
…es in docs

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #2957 (c74f8cc) into master (d0d27a3) will decrease coverage by 19.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2957       +/-   ##
===========================================
- Coverage   77.67%   58.48%   -19.20%     
===========================================
  Files         186      186               
  Lines       16339    16339               
===========================================
- Hits        12692     9556     -3136     
- Misses       3647     6783     +3136     
Flag Coverage Δ
integrationtests ?
unittests 58.48% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...python/tests/unit/infra/test_key_encoding_utils.py 100.00% <ø> (ø)
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-80.00%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.36% <0.00%> (-76.64%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-74.20%) ⬇️
...ts/integration/offline_store/test_offline_write.py 27.69% <0.00%> (-72.31%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 28.84% <0.00%> (-69.24%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d27a3...c74f8cc. Read the comment docs.

Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Danny Chiao <danny@tecton.ai>
@achals
Copy link
Member

achals commented Jul 20, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit 6d7b38a into feast-dev:master Jul 20, 2022
adchia added a commit that referenced this pull request Jul 21, 2022
)

* docs: Include docs updates for release process. Clean up old references in docs

Signed-off-by: Danny Chiao <danny@tecton.ai>

* clean up third integrations page

Signed-off-by: Danny Chiao <danny@tecton.ai>

* clean up lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

* add clarification on credentials

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the updateDocs branch July 21, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants