Skip to content

fix: Add dummy alias to pull_all_from_table_or_query #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Jul 21, 2022
Merged

fix: Add dummy alias to pull_all_from_table_or_query #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
245bd03
Add dummy alias to pull_all_from_table_or_query
ikrizanic Jul 20, 2022
b73d640
Fix lint error
ikrizanic Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def pull_all_from_table_or_query(

query = f"""
SELECT {field_string}
FROM {from_expression}
FROM {from_expression} AS paftoq_alias
WHERE "{timestamp_field}" BETWEEN '{start_date}'::timestamptz AND '{end_date}'::timestamptz
"""

Expand Down
6 changes: 3 additions & 3 deletions sdk/python/tests/unit/infra/test_key_encoding_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ def test_serialize_entity_key():
# Should be fine
serialize_entity_key(
EntityKeyProto(
join_keys=["user"], entity_values=[ValueProto(int64_val=int(2 ** 15))]
join_keys=["user"], entity_values=[ValueProto(int64_val=int(2**15))]
),
entity_key_serialization_version=2,
)
# True int64, but should also be fine.
serialize_entity_key(
EntityKeyProto(
join_keys=["user"], entity_values=[ValueProto(int64_val=int(2 ** 31))]
join_keys=["user"], entity_values=[ValueProto(int64_val=int(2**31))]
),
entity_key_serialization_version=2,
)
Expand All @@ -25,6 +25,6 @@ def test_serialize_entity_key():
with pytest.raises(BaseException):
serialize_entity_key(
EntityKeyProto(
join_keys=["user"], entity_values=[ValueProto(int64_val=int(2 ** 31))]
join_keys=["user"], entity_values=[ValueProto(int64_val=int(2**31))]
),
)