Skip to content

chore: Upgrade GCP dependencies #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevjumba merged 7 commits into from
Jul 19, 2022
Merged

chore: Upgrade GCP dependencies #2945

kevjumba merged 7 commits into from
Jul 19, 2022

Conversation

@chhabrakadabra
Copy link
Collaborator

@chhabrakadabra chhabrakadabra commented Jul 15, 2022 •
edited
Loading

Signed-off-by: Abhin Chhabra abhin.chhabra@shopify.com

What this PR does / why we need it:

I'm pulling out the GCP upgrades out of #2928 since that PR was going to get gnarly. This PR just focuses on GCP upgrades.

Which issue(s) this PR fixes:

Partially completes #2906

Remaining tasks

  • Generate lockfiles for other versions of Python
  • Fix the failing integration tests

chhabrakadabra
chhabrakadabra commented Jul 15, 2022
View reviewed changes
sdk/python/feast/infra/offline_stores/bigquery.py Outdated
Copy link
Collaborator Author

@chhabrakadabra chhabrakadabra Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function seems to always return a string, so the optional type is wrong. Mypy was complaining about one of its usages.

chhabrakadabra
chhabrakadabra commented Jul 15, 2022
View reviewed changes
sdk/python/tests/integration/feature_repos/universal/data_sources/bigquery.py Outdated
Copy link
Collaborator Author

@chhabrakadabra chhabrakadabra Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might pull this out into a helper function if the maintainers validate this approach.

Copy link
Collaborator

@kevjumba kevjumba Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks fine!

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022 •
edited
Loading

Codecov Report

Merging #2945 (848de59) into master (d593351) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2945      +/-   ##
==========================================
- Coverage   78.65%   78.62%   -0.04%     
==========================================
  Files         184      184              
  Lines       16305    16313       +8     
==========================================
+ Hits        12825    12826       +1     
- Misses       3480     3487       +7
Flag Coverage Δ
integrationtests 68.67% <83.33%> (-0.12%) ⬇️
unittests 59.42% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 86.36% <0.00%> (ø)
setup.py 0.00% <ø> (ø)
sdk/python/feast/feature_store.py 85.84% <66.66%> (ø)
sdk/python/feast/utils.py 92.63% <100.00%> (+0.49%) ⬆️
...n/feature_repos/universal/data_sources/bigquery.py 98.11% <100.00%> (+0.07%) ⬆️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d593351...848de59. Read the comment docs.

@kevjumba kevjumba marked this pull request as ready for review July 18, 2022 22:15
chhabrakadabra and others added 6 commits July 18, 2022 16:16
@chhabrakadabra @kevjumba
Upgrade GCP dependencies.
43cfc0f 
Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com>
@chhabrakadabra @kevjumba
entity_df in get_historical_features should be tzaware
831665f 
Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com>
@chhabrakadabra @kevjumba
Linting fixes
c25c7c8 
Signed-off-by: Abhin Chhabra <abhin.chhabra@shopify.com>
@kevjumba
Update 3.9 reqs
84ad65c 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
@kevjumba
Fix
78328f0 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
@kevjumba
Remove unnecessary code coverage
e1fa1fc 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
@kevjumba
Fix
848de59 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
felixwang9817
felixwang9817 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, chhabrakadabra, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevjumba kevjumba merged commit d3868c5 into feast-dev:master Jul 19, 2022
@chhabrakadabra chhabrakadabra deleted the upgrade-gcp-libs branch July 19, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevjumba kevjumba kevjumba left review comments

@achals achals achals approved these changes

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm ok-to-test size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chhabrakadabra @codecov-commenter @feast-ci-bot @achals @kevjumba @felixwang9817