Skip to content

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Jul 8, 2022

Signed-off-by: Danny Chiao danny@tecton.ai

What this PR does / why we need it:
I pushed a new NPM release for the UI model to fix recent issues. This updates Feast to use that new npm module (though strictly speaking, this isn't necessary because "^" includes newer patch releases

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 495f5f0 into feast-dev:master Jul 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2924 (335fc70) into master (66038c7) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2924      +/-   ##
==========================================
- Coverage   80.79%   80.73%   -0.06%     
==========================================
  Files         179      179              
  Lines       15870    15870              
==========================================
- Hits        12822    12813       -9     
- Misses       3048     3057       +9     
Flag Coverage Δ
integrationtests 70.99% <ø> (-0.14%) ⬇️
unittests 59.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.39% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66038c7...335fc70. Read the comment docs.

adchia added a commit that referenced this pull request Jul 14, 2022
chore: Update Feast UI dependency

Signed-off-by: Danny Chiao <danny@tecton.ai>
kevjumba pushed a commit that referenced this pull request Jul 19, 2022
chore: Update Feast UI dependency

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the updateFeastUI branch July 21, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants