Skip to content

docs: Grammatically updated the quickstart guide docs #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feast-ci-bot merged 1 commit into from
Jul 6, 2022
Merged

docs: Grammatically updated the quickstart guide docs #2913

feast-ci-bot merged 1 commit into from
Jul 6, 2022

Conversation

@prasadzende
Copy link
Contributor

@prasadzende prasadzende commented Jul 6, 2022

What this PR does / why we need it:

A small grammatical update to quickstart tutorial guide docs.

Which issue(s) this PR fixes:

Fixes #

@prasadzende
Grammatically updated the quickstart guide docs
deca686 
Signed-off-by: Prasad <prasadzende1997@gmail.com>
@prasadzende prasadzende changed the title Grammatically updated the quickstart guide docs docs: Grammatically updated the quickstart guide docs Jul 6, 2022
@achals
Copy link
Member

achals commented Jul 6, 2022

/ok-to-test
/approve
/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Jul 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, prasadzende

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsotnet tsotnet removed their assignment Jul 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022 •
edited
Loading

Codecov Report

Merging #2913 (deca686) into master (0159f38) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2913      +/-   ##
==========================================
- Coverage   80.68%   80.62%   -0.06%     
==========================================
  Files         178      178              
  Lines       15837    15837              
==========================================
- Hits        12778    12769       -9     
- Misses       3059     3068       +9
Flag Coverage Δ
integrationtests 70.84% <ø> (-0.15%) ⬇️
unittests 59.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.39% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0159f38...deca686. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit eaf4022 into feast-dev:master Jul 6, 2022
adchia pushed a commit that referenced this pull request Jul 14, 2022
@prasadzende @adchia
docs: Grammatically updated the quickstart guide docs (#2913)
1474c1e 
Signed-off-by: Prasad <prasadzende1997@gmail.com>
kevjumba pushed a commit that referenced this pull request Jul 19, 2022
@prasadzende @kevjumba
docs: Grammatically updated the quickstart guide docs (#2913)
d36bf65 
Signed-off-by: Prasad <prasadzende1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@achals achals

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@prasadzende @achals @feast-ci-bot @codecov-commenter @tsotnet