Skip to content

Conversation

@felixwang9817
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #2912 (68f972c) into master (38fd001) will decrease coverage by 21.06%.
The diff coverage is 23.52%.

@@             Coverage Diff             @@
##           master    #2912       +/-   ##
===========================================
- Coverage   80.67%   59.60%   -21.07%     
===========================================
  Files         180      179        -1     
  Lines       15842    15806       -36     
===========================================
- Hits        12780     9421     -3359     
- Misses       3062     6385     +3323     
Flag Coverage Δ
integrationtests ?
unittests 59.60% <23.52%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 17.47% <0.00%> (-73.77%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <8.33%> (-70.50%) ⬇️
...tests/integration/online_store/test_push_online.py 40.00% <20.00%> (ø)
...sts/integration/offline_store/test_push_offline.py 38.46% <28.57%> (ø)
...ts/integration/offline_store/test_offline_write.py 27.69% <29.41%> (-72.31%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <33.33%> (-67.75%) ⬇️
sdk/python/tests/conftest.py 66.66% <50.00%> (-11.81%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <100.00%> (-65.22%) ⬇️
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fd001...68f972c. Read the comment docs.

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit dcd8ec9 into feast-dev:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants