chore: Change pytest fixtures to be function-scoped instead of session-scoped #2899
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
- Coverage 80.65% 80.58% -0.07%
==========================================
Files 176 177 +1
Lines 15663 15679 +16
==========================================
+ Hits 12633 12635 +2
- Misses 3030 3044 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
look sgood btw |
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
force-pushed
the
pytest_scoping
branch
from
4d9505c to
9e27fce
Compare
felixwang9817
changed the title
|
/lgtm |
|
|
||
|
|
||
| @pytest.mark.integration | ||
| def test_apply_first_entity(environment): |
There was a problem hiding this comment.
If the Scopes have been changed i don't see a huge point to these tests - even if there's a race condition in the future it seems like the repro for that will need it's own test. Wdyt?
There was a problem hiding this comment.
yeah this is fair; I'll remove this in some future PR when I clean up test suite
…n-scoped (#2899) * Test to trigger registry conflicts Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Switch environment and associated fixtures to being function scoped Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Format Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Switch type tests to function-scoped fixtures Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Format Signed-off-by: Felix Wang <wangfelix98@gmail.com>
…n-scoped (#2899) * Test to trigger registry conflicts Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Switch environment and associated fixtures to being function scoped Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Format Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Switch type tests to function-scoped fixtures Signed-off-by: Felix Wang <wangfelix98@gmail.com> * Format Signed-off-by: Felix Wang <wangfelix98@gmail.com>
5 participants
What this PR does / why we need it: This PR changes the scope of several pytest fixtures, including
environmentto function-scoped instead of session-scoped. This will ensure that each test environment is separate. It also adds a test to confirm that each test environment is separate.Which issue(s) this PR fixes:
Fixes #