Skip to content

chore: Verification workflow in build wheels that ensures the wheels built are not development and the correct versions #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 23 commits into from
Jun 30, 2022
Merged

chore: Verification workflow in build wheels that ensures the wheels built are not development and the correct versions #2893

Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
40eaea6
Test
kevjumba Jun 29, 2022
a33fdfd
Fix
kevjumba Jun 29, 2022
933b330
Fix
kevjumba Jun 29, 2022
7b43272
Fix workflow
kevjumba Jun 29, 2022
7a3c569
Fix workflow
kevjumba Jun 29, 2022
299cd23
Test
kevjumba Jun 29, 2022
49fa7e1
Fix
kevjumba Jun 29, 2022
a84fbde
Fix
kevjumba Jun 29, 2022
8b8ac51
Fix
kevjumba Jun 29, 2022
c26f4dc
Fix
kevjumba Jun 29, 2022
b005958
test
kevjumba Jun 29, 2022
5b4f6e3
Fix
kevjumba Jun 29, 2022
4f7abd7
Fix
kevjumba Jun 29, 2022
1f78fd3
Fix
kevjumba Jun 29, 2022
514ddd0
Fix
kevjumba Jun 29, 2022
00b20f9
Fix
kevjumba Jun 29, 2022
3abd6b7
test
kevjumba Jun 29, 2022
39fd3dc
Merge pull request #20 from kevjumba/verification_workflow
kevjumba Jun 29, 2022
2c4b22a
Fix
kevjumba Jun 29, 2022
81e7b6c
Fix
kevjumba Jun 29, 2022
e8f7c09
Fix
kevjumba Jun 29, 2022
839277c
Fix
kevjumba Jun 29, 2022
2047380
Fix
kevjumba Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
name: build_wheels

# Call this workflow from other workflows in the repository by specifying "uses: ./.github/workflows/build_wheels.yml"
on: [workflow_dispatch, workflow_call]
# Developers who are starting a new release should use this workflow to ensure wheels will be built correctly.
# Devs should check out their fork, add a tag to the last master commit on their fork, and run the release off of their fork on the added tag to ensure wheels will be built correctly.
on:
workflow_dispatch:
tags:
- 'v*.*.*'
workflow_call:

jobs:
get-version:
Expand Down Expand Up @@ -134,7 +140,7 @@ jobs:

verify-python-wheels:
runs-on: ${{ matrix.os }}
needs: [build-python-wheel, build-source-distribution]
needs: [build-python-wheel, build-source-distribution, get-version]
strategy:
matrix:
os: [ubuntu-latest, macos-10.15 ]
Expand All @@ -153,6 +159,7 @@ jobs:
else
echo "Succeeded!"
fi
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
steps:
- name: Setup Python
id: setup-python
Expand Down Expand Up @@ -190,6 +197,19 @@ jobs:
- name: Install OS X dependencies
if: matrix.os == 'macos-10.15'
run: brew install coreutils
# Validate that the feast version installed is not development and is the correct version of the tag we ran it off of.
- name: Validate Feast Version
run: |
VERSION_REGEX='[0-9]+\.[0-9]+\.[0-9]+'
OUTPUT_REGEX='^Feast SDK Version: "$VERSION_REGEX"$'
VERSION_OUTPUT=$(feast version)
VERSION=$(echo $VERSION_OUTPUT | grep -oE "$VERSION_REGEX")
OUTPUT=$(echo $VERSION_OUTPUT | grep -E "$REGEX")
if [ -n "$OUTPUT" ] && [ "$VERSION" = "$VERSION_WITHOUT_PREFIX" ]; then
echo "Correct Feast Version Installed"
else
echo "$VERSION_OUTPUT from installed wheel is not in the correct format or doesn't have the right version $VERSION."
fi
- name: Smoke test
run: |
feast init test_repo
Expand All @@ -198,6 +218,7 @@ jobs:
echo "$TEST_SCRIPT" > run-and-wait.sh
bash run-and-wait.sh feast serve
bash run-and-wait.sh feast ui

# We disable this test for the Python 3.10 binary since it does not include Go.
- name: Smoke test with go
if: matrix.python-version != '3.10' || matrix.os == 'ubuntu-latest'
Expand Down