Skip to content

fix: Renable tests after fixing gopy installation issue that was blocking tests. #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevjumba wants to merge 2 commits into from
Closed

fix: Renable tests after fixing gopy installation issue that was blocking tests. #2841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae70387
Renable tests
kevjumba Jun 23, 2022
e104b8a
Renable tests
kevjumba Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sdk/python/tests/integration/e2e/test_go_feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def grpc_client(grpc_server_port):


@pytest.mark.integration
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
@pytest.mark.goserver
def test_go_grpc_server(grpc_client):
resp: GetOnlineFeaturesResponse = grpc_client.GetOnlineFeatures(
GetOnlineFeaturesRequest(
Expand All @@ -148,7 +148,7 @@ def test_go_grpc_server(grpc_client):


@pytest.mark.integration
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
@pytest.mark.goserver
def test_go_http_server(http_server_port):
response = requests.post(
f"http://localhost:{http_server_port}/get-online-features",
Expand Down Expand Up @@ -186,7 +186,7 @@ def test_go_http_server(http_server_port):


@pytest.mark.integration
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
@pytest.mark.goserver
@pytest.mark.universal_offline_stores
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v))
def test_feature_logging(
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/online_store/test_universal_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ def test_online_retrieval_with_event_timestamps(

@pytest.mark.integration
@pytest.mark.universal_online_stores
# @pytest.mark.goserver Disabling because the go fs tests are flaking in CI. TODO(achals): uncomment after fixed.
@pytest.mark.goserver
@pytest.mark.parametrize("full_feature_names", [True, False], ids=lambda v: str(v))
def test_stream_feature_view_online_retrieval(
environment, universal_data_sources, feature_server_endpoint, full_feature_names
Expand Down