Skip to content

ci: Add a test timeout and print thread stack trace on timeouts#2823

Merged
kevjumba merged 1 commit intofeast-dev:masterfrom
achals:achal/pytest-timeout
Jun 21, 2022
Merged

ci: Add a test timeout and print thread stack trace on timeouts#2823
kevjumba merged 1 commit intofeast-dev:masterfrom
achals:achal/pytest-timeout

Conversation

@achals
Copy link
Copy Markdown
Member

@achals achals commented Jun 21, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

https://pypi.org/project/pytest-timeout/

Now you can run the test suite while setting a timeout in seconds, any individual test which takes longer than the given duration will be terminated:

This should help us get an idea why tests are hanging in CI right now.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #2823 (0a3ff4a) into master (3dd779f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2823   +/-   ##
=======================================
  Coverage   59.63%   59.63%           
=======================================
  Files         174      174           
  Lines       15493    15493           
=======================================
  Hits         9239     9239           
  Misses       6254     6254           
Flag Coverage Δ
unittests 59.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd779f...0a3ff4a. Read the comment docs.

@kevjumba kevjumba merged commit 810eeab into feast-dev:master Jun 21, 2022
@achals achals deleted the achal/pytest-timeout branch June 21, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants