Skip to content

chore: Refactor some minor issues in Java modules#2787

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
yanghua:FEAST-3
Jun 13, 2022
Merged

chore: Refactor some minor issues in Java modules#2787
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
yanghua:FEAST-3

Conversation

@yanghua
Copy link
Copy Markdown
Contributor

@yanghua yanghua commented Jun 13, 2022

Signed-off-by: yanghua yanghua1127@gmail.com

What this PR does / why we need it:

Refactor some minor issues when reading some java related modules.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: yanghua <yanghua1127@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #2787 (330a112) into master (88cc47d) will decrease coverage by 20.86%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2787       +/-   ##
===========================================
- Coverage   80.59%   59.73%   -20.87%     
===========================================
  Files         173      173               
  Lines       15134    15240      +106     
===========================================
- Hits        12198     9103     -3095     
- Misses       2936     6137     +3201     
Flag Coverage Δ
integrationtests ?
unittests 59.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.80% <0.00%> (-76.20%) ⬇️
.../integration/online_store/test_universal_online.py 17.43% <0.00%> (-73.03%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 23.52% <0.00%> (-72.90%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cc47d...330a112. Read the comment docs.

@adchia adchia changed the title fix: Refactor some minor issues /assign @felixwang9817 chore: Refactor some minor issues in Java modules Jun 13, 2022
Copy link
Copy Markdown
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, yanghua

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit a49cc35 into feast-dev:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants