Skip to content

ci: Use buildx for docker builds in remaining places as well#2705

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
achals:achal/fix-other-builds
May 16, 2022
Merged

ci: Use buildx for docker builds in remaining places as well#2705
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
achals:achal/fix-other-builds

Conversation

@achals

@achals achals commented May 16, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals
ci: Use buildx for docker builds in remaining places as well
7f05ed1 
Signed-off-by: Achal Shah <achals@gmail.com>
adchia
adchia approved these changes May 16, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@achals
fix oops
358d080 
Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label May 16, 2022
@codecov-commenter

codecov-commenter commented May 16, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.43%. Comparing base (2d56963) to head (358d080).
⚠️ Report is 1940 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
- Coverage   80.95%   80.43%   -0.52%     
==========================================
  Files         166      166              
  Lines       13888    13981      +93     
==========================================
+ Hits        11243    11246       +3     
- Misses       2645     2735      +90
Flag Coverage Δ
integrationtests 71.11% <ø> (-0.62%) ⬇️
unittests 58.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

adchia
adchia approved these changes May 16, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented May 16, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pyalex

pyalex commented May 16, 2022

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 095dfd6 into feast-dev:master May 16, 2022
@achals achals deleted the achal/fix-other-builds branch May 16, 2022 20:54
adchia pushed a commit that referenced this pull request May 16, 2022
@achals @adchia
ci: Use buildx for docker builds in remaining places as well (#2705)
156c6f1 
* ci: Use buildx for docker builds in remaining places as well

Signed-off-by: Achal Shah <achals@gmail.com>

* fix oops

Signed-off-by: Achal Shah <achals@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Assignees

@pyalex pyalex

@adchia adchia

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@achals @codecov-commenter @feast-ci-bot @pyalex @adchia