Skip to content

chore: Test all wheels for basic functionality before publishing to pypi#2687

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
pyalex:wheel-verification
May 13, 2022
Merged

chore: Test all wheels for basic functionality before publishing to pypi#2687
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
pyalex:wheel-verification

Conversation

@pyalex

@pyalex pyalex commented May 13, 2022

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

After all wheels are built we run additional step to install each wheel and verify that installed package is fully operational.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@pyalex pyalex force-pushed the wheel-verification branch from 3c61d93 to 4eeab07 Compare May 13, 2022 20:31
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals

achals commented May 13, 2022

Copy link
Copy Markdown
Member

/lgtm

@codecov-commenter

codecov-commenter commented May 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2687 (301c91f) into master (01d3568) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
- Coverage   80.99%   80.92%   -0.08%     
==========================================
  Files         166      166              
  Lines       13872    13881       +9     
==========================================
- Hits        11236    11233       -3     
- Misses       2636     2648      +12     
Flag Coverage Δ
integrationtests 71.46% <0.00%> (-0.30%) ⬇️
unittests 58.64% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
sdk/python/feast/infra/aws.py 71.77% <0.00%> (-0.96%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.65% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d3568...301c91f. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit bcdce32 into feast-dev:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants