Skip to content

Conversation

@achals
Copy link
Member

@achals achals commented May 9, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #2652 (9b5027a) into master (bdeb4ae) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   78.57%   78.52%   -0.06%     
==========================================
  Files         179      179              
  Lines       15877    15877              
==========================================
- Hits        12475    12467       -8     
- Misses       3402     3410       +8     
Flag Coverage Δ
integrationtests 68.34% <ø> (-0.14%) ⬇️
unittests 59.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdeb4ae...9b5027a. Read the comment docs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary comment?

kevjumba and others added 3 commits July 11, 2022 15:20
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 4394696 into feast-dev:master Jul 12, 2022
kevjumba added a commit that referenced this pull request Jul 19, 2022
* Remove 3.7 wheels

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* ci: Add a nightly CI job for integration tests

Signed-off-by: Achal Shah <achals@gmail.com>

* Update and rebase

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

* Fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>

Co-authored-by: Kevin Zhang <kzhang@tecton.ai>
adchia added a commit that referenced this pull request Jul 28, 2022
…2652)"

This reverts commit 6645efb.

Signed-off-by: Danny Chiao <danny@tecton.ai>
adchia pushed a commit that referenced this pull request Jul 29, 2022
## [0.22.2](v0.22.1...v0.22.2) (2022-07-29)

### Reverts

* **ci:** "Fix night ci syntax error and update readme ([#2935](#2935))" ([31f54c8](31f54c8))
* **ci:** fix: Fix nightly ci again ([#2939](#2939)). This reverts commit c363619. ([33cbaeb](33cbaeb))
* **ci:** Revert "ci: Add a nightly CI job for integration tests ([#2652](#2652))" ([d4bb394](d4bb394))
* **ci:** Revert "fix: Deprecate 3.7 wheels and fix verification workflow ([#2934](#2934))" ([efadb22](efadb22))
* Revert "fix: Change numpy version on setup.py and upgrade it to resolve dependabot warning ([#2887](#2887))" ([87190cb](87190cb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants