Skip to content

Conversation

@achals
Copy link
Member

@achals achals commented May 9, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

achals added 3 commits May 6, 2022 11:31
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #2650 (53a0170) into master (5b4b07f) will decrease coverage by 0.16%.
The diff coverage is 56.56%.

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
- Coverage   80.65%   80.49%   -0.17%     
==========================================
  Files         163      163              
  Lines       13734    13815      +81     
==========================================
+ Hits        11077    11120      +43     
- Misses       2657     2695      +38     
Flag Coverage Δ
integrationtests 71.22% <61.53%> (-0.41%) ⬇️
unittests 58.61% <50.50%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...line_stores/contrib/postgres_repo_configuration.py 100.00% <ø> (ø)
...thon/feast/infra/online_stores/contrib/postgres.py 32.69% <ø> (ø)
setup.py 0.00% <ø> (ø)
...n/feature_repos/universal/data_sources/postgres.py 57.31% <52.85%> (+3.74%) ⬆️
sdk/python/tests/conftest.py 81.50% <65.51%> (-3.33%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.65% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b4b07f...53a0170. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 640ff12 into feast-dev:master May 9, 2022
@achals achals deleted the achal/postgres-continer branch May 9, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants