Skip to content

chore: Remove unused scripts and docker-compose env#2642

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/remove-scripts
May 5, 2022
Merged

chore: Remove unused scripts and docker-compose env#2642
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/remove-scripts

Conversation

@achals

@achals achals commented May 5, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals
chore: Remove unused scripts and docker-compose env
b229a69 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter

codecov-commenter commented May 5, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (f22430a) to head (b229a69).
Report is 1196 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
- Coverage   80.69%   80.62%   -0.07%     
==========================================
  Files         163      163              
  Lines       13727    13727              
==========================================
- Hits        11077    11068       -9     
- Misses       2650     2659       +9
Flag Coverage Δ
integrationtests 71.33% <ø> (-0.40%) ⬇️
unittests 58.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevjumba

kevjumba commented May 5, 2022

Copy link
Copy Markdown
Collaborator

/ok-to-test

@kevjumba

kevjumba commented May 5, 2022

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 1758be3 into feast-dev:master May 5, 2022
felixwang9817
felixwang9817 approved these changes May 5, 2022
View reviewed changes

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented May 5, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@kevjumba kevjumba

Labels

approved lgtm ok-to-test size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@achals @codecov-commenter @kevjumba @feast-ci-bot @felixwang9817