Skip to content

feat: Allow to pass secrets and environment variables to transformation service #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
May 10, 2022
Merged

feat: Allow to pass secrets and environment variables to transformation service #2632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/charts/feast/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: Feature store for machine learning
name: feast
version: 0.20.0
version: 0.20.1
keywords:
- machine learning
- big data
Expand Down
29 changes: 27 additions & 2 deletions infra/charts/feast/charts/transformation-service/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,44 @@ spec:
nodeSelector:
{{- toYaml . | nindent 8 }}
{{- end }}

volumes:
{{- range $secret := .Values.secrets }}
- name: {{ $secret }}
secret:
secretName: {{ $secret }}
{{- end }}

containers:
- name: {{ .Chart.Name }}
image: {{ .Values.image.repository }}:{{ .Values.image.tag }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- name: grpc
containerPort: {{ .Values.service.grpc.targetPort }}


volumeMounts:
{{- range $secret := .Values.secrets }}
- name: {{ $secret }}
mountPath: "/etc/secrets/{{ $secret }}"
readOnly: true
{{- end }}

env:
- name: FEATURE_TRANSFORMATION_SERVER_PORT
value: {{ .Values.service.grpc.targetPort | quote }}
- name: FEATURE_STORE_YAML_BASE64
value: {{ tpl (.Files.Get "config/feature_store.yaml") . | b64enc | quote }}


{{- range $key, $value := .Values.envOverrides }}
- name: {{ printf "%s" $key | replace "." "_" | upper | quote }}
{{- if eq (kindOf $value) "map" }}
valueFrom:
{{- toYaml $value | nindent 12 }}
{{- else }}
value: {{ $value | quote }}
{{- end }}
{{- end }}

resources:
{{- toYaml .Values.resources | nindent 10 }}
3 changes: 3 additions & 0 deletions infra/charts/feast/charts/transformation-service/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@ nodeSelector: {}
# envOverrides -- Extra environment variables to set
envOverrides: {}

# secrets -- List of Kubernetes secrets to be mounted. These secrets will be mounted on /etc/secrets/<secret name>.
secrets: []

# podLabels -- Labels to be added to Feast Serving pods
podLabels: {}