Skip to content

chore: Update python packaging to use build to produce sdists/wheels#2630

Merged
feast-ci-bot merged 10 commits intofeast-dev:masterfrom
achals:achal/update-python-builds
May 3, 2022
Merged

chore: Update python packaging to use build to produce sdists/wheels#2630
feast-ci-bot merged 10 commits intofeast-dev:masterfrom
achals:achal/update-python-builds

Conversation

@achals
Copy link
Copy Markdown
Member

@achals achals commented May 2, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals achals force-pushed the achal/update-python-builds branch from d4df01a to f48d3f4 Compare May 2, 2022 17:32
Signed-off-by: Achal Shah <achals@gmail.com>
achals added 6 commits May 2, 2022 10:46
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 2, 2022

Codecov Report

Merging #2630 (232e25e) into master (cff0133) will decrease coverage by 1.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2630      +/-   ##
==========================================
- Coverage   81.50%   80.41%   -1.09%     
==========================================
  Files         162      163       +1     
  Lines       13380    13553     +173     
==========================================
- Hits        10905    10899       -6     
- Misses       2475     2654     +179     
Flag Coverage Δ
integrationtests 70.94% <0.00%> (-1.40%) ⬇️
unittests 58.75% <0.00%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
...ython/feast/embedded_go/online_features_service.py 96.11% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff0133...232e25e. Read the comment docs.

Signed-off-by: Achal Shah <achals@gmail.com>
@achals achals changed the title chore: Update python packaging to use build and produce sdists/wheels chore: Update python packaging to use build to produce sdists/wheels May 3, 2022
@achals achals marked this pull request as ready for review May 3, 2022 16:28
Signed-off-by: Achal Shah <achals@gmail.com>
@kevjumba
Copy link
Copy Markdown
Collaborator

kevjumba commented May 3, 2022

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d59a91c into feast-dev:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants