Skip to content

chore: Extra dependencies in setup.py for Go <-> Python interop #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feast-ci-bot merged 2 commits into from
Apr 21, 2022
Merged

chore: Extra dependencies in setup.py for Go <-> Python interop #2589

feast-ci-bot merged 2 commits into from
Apr 21, 2022

Conversation

@pyalex
Copy link
Collaborator

@pyalex pyalex commented Apr 21, 2022 •
edited
Loading

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

In order for Python to fully interop with Go we might need to install some extra python packages. This PR adds new dependency group go to setup.py.

Which issue(s) this PR fixes:

Fixes #

@pyalex
install go dependencies
adabcb2 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
achals
achals reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some context in the PR description?

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #2589 (eab7084) into master (104155c) will decrease coverage by 22.51%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2589       +/-   ##
===========================================
- Coverage   82.34%   59.83%   -22.52%     
===========================================
  Files         154      153        -1     
  Lines       12735    12623      -112     
===========================================
- Hits        10487     7553     -2934     
- Misses       2248     5070     +2822
Flag Coverage Δ
integrationtests ?
unittests 59.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
.../integration/online_store/test_universal_online.py 16.83% <0.00%> (-78.70%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.88% <0.00%> (-76.12%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.57% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-67.91%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 33.92% <0.00%> (-66.08%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104155c...eab7084. Read the comment docs.

@pyalex
allow patch versions for cffi
eab7084 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@achals
Copy link
Member

achals commented Apr 21, 2022

Also, do we need to change any of our packaging scripts?

adchia
adchia approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Apr 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 19f1f46 into feast-dev:master Apr 21, 2022
kevjumba pushed a commit that referenced this pull request Apr 28, 2022
@pyalex @kevjumba
chore: Extra dependencies in setup.py for Go <-> Python interop (#2589)
a846530 
* install go dependencies

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>

* allow patch versions for cffi

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals left review comments

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pyalex @codecov-commenter @achals @feast-ci-bot @adchia