Skip to content

chore: Add Snowflake to AWS Lambda feature server Dockerfile#2565

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
felixwang9817:aws_snowflake_bug
Apr 18, 2022
Merged

chore: Add Snowflake to AWS Lambda feature server Dockerfile#2565
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
felixwang9817:aws_snowflake_bug

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented Apr 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2560

@felixwang9817
Add Snowflake to AWS Lambda feature server Dockerfile
7ae59d5 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@achals

achals commented Apr 18, 2022

Copy link
Copy Markdown
Member

Discussed offline; we're gonna ship this to close out #2560 but a more proper fix needs working on that will make the loading of the online and offline stores lazy.

@felixwang9817
Add TODO
9090f21 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 mentioned this pull request Apr 18, 2022
Closed
@felixwang9817

felixwang9817 commented Apr 18, 2022

Copy link
Copy Markdown
Collaborator Author

Discussed offline; we're gonna ship this to close out #2560 but a more proper fix needs working on that will make the loading of the online and offline stores lazy.

#2566 tracks the correct fix.

@codecov-commenter

codecov-commenter commented Apr 18, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2565 (9090f21) into master (b10a4cf) will decrease coverage by 23.64%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2565       +/-   ##
===========================================
- Coverage   82.81%   59.17%   -23.65%     
===========================================
  Files         141      140        -1     
  Lines       11947    11835      -112     
===========================================
- Hits         9894     7003     -2891     
- Misses       2053     4832     +2779
Flag Coverage Δ
integrationtests ?
unittests 59.17% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-80.00%) ⬇️
.../integration/online_store/test_universal_online.py 16.83% <0.00%> (-78.36%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.88% <0.00%> (-76.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-74.20%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-67.91%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 33.92% <0.00%> (-66.08%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...s/integration/registration/test_universal_types.py 35.36% <0.00%> (-63.42%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10a4cf...9090f21. Read the comment docs.

achals
achals approved these changes Apr 18, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Apr 18, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 54ad3b6 into feast-dev:master Apr 18, 2022
adchia pushed a commit that referenced this pull request Apr 20, 2022
@felixwang9817 @adchia
chore: Add Snowflake to AWS Lambda feature server Dockerfile (#2565)
07ec4c5 
* Add Snowflake to AWS Lambda feature server Dockerfile

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Add TODO

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SnowflakeOfflineStoreConfig import fails in the python feature server

4 participants

@felixwang9817 @achals @codecov-commenter @feast-ci-bot