Skip to content

Conversation

@felixwang9817
Copy link
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Tests on master were recently failing due to the setup-gcloud action being pinned to master. In the near future, master will be renamed to main; moreover, we should not be pinning to master anyways. This PR pins the setup-gcloud action to v0 instead.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 requested a review from a team as a code owner March 22, 2022 17:30
@felixwang9817 felixwang9817 requested review from woop and removed request for a team March 22, 2022 17:30
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817 felixwang9817 changed the title Pin setup-gcloud actions to v0 instead of master ci: Pin setup-gcloud actions to v0 instead of master Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #2434 (f0c7a28) into master (e14369d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2434   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         122      122           
  Lines       10704    10704           
=======================================
  Hits         8930     8930           
  Misses       1774     1774           
Flag Coverage Δ
integrationtests 73.16% <ø> (-0.26%) ⬇️
unittests 57.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14369d...f0c7a28. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit 5e6d9bc into feast-dev:master Mar 22, 2022
felixwang9817 added a commit that referenced this pull request Apr 6, 2022
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants