Skip to content

ci: Ensure lgtm also triggers Java PR tests and fix YAML formatting#2396

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
felixwang9817:fix_java_tests
Mar 10, 2022
Merged

ci: Ensure lgtm also triggers Java PR tests and fix YAML formatting#2396
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
felixwang9817:fix_java_tests

Conversation

@felixwang9817

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Recently #2385 ensured that Python integration tests run when a PR is given the lgtm label, but did not make the same change for Java integration tests. This PR applies the same change for Java integration tests.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 requested a review from a team as a code owner March 10, 2022 18:39
@felixwang9817 felixwang9817 requested review from pyalex and removed request for a team March 10, 2022 18:39
@felixwang9817 felixwang9817 requested review from achals and removed request for pyalex March 10, 2022 18:39

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented Mar 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2396 (125235f) into master (0bb5e8c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2396   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         122      122           
  Lines       10713    10713           
=======================================
  Hits         9149     9149           
  Misses       1564     1564           
Flag Coverage Δ
integrationtests 75.24% <ø> (-0.22%) ⬇️
unittests 57.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/go_server.py 89.18% <0.00%> (-0.68%) ⬇️
.../integration/online_store/test_universal_online.py 96.68% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb5e8c...125235f. Read the comment docs.

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@achals

achals commented Mar 10, 2022

Copy link
Copy Markdown
Member

/lgtm

@feast-ci-bot feast-ci-bot merged commit 9aa96b9 into feast-dev:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants