Skip to content

feat: Makefile for contrib for Issue #2364 #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 8 commits into from
Mar 8, 2022
Merged

feat: Makefile for contrib for Issue #2364 #2366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2a9fad0
Add make file
kevjumba Mar 4, 2022
a881e18
Fix makefile
kevjumba Mar 5, 2022
ad0bad0
Clean up
kevjumba Mar 5, 2022
72c3938
Add documentation
kevjumba Mar 5, 2022
2d24115
Clean up
kevjumba Mar 5, 2022
c59fd05
Update documentation
kevjumba Mar 7, 2022
5c31897
update make target
kevjumba Mar 7, 2022
6e7a30c
Merge branch 'master' into makefile_for_contrib
adchia Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ test-python:
test-python-integration:
FEAST_USAGE=False IS_TEST=True python -m pytest -n 8 --integration sdk/python/tests

test-python-universal-contrib:
PYTHONPATH='.' FULL_REPO_CONFIGS_MODULE=sdk.python.feast.infra.offline_stores.contrib.contrib_repo_configuration FEAST_USAGE=False IS_TEST=True python -m pytest -n 8 --integration --universal sdk/python/tests
Copy link
Member

@woop woop Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is PYTHONPATH added here?

Copy link
Collaborator Author

@kevjumba kevjumba Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just temporarily changes the path so that we can use the module from the feast directory. I was having trouble importing the repo configs module as an absolute path using the root directory.


test-python-universal-local:
FEAST_USAGE=False IS_TEST=True FEAST_IS_LOCAL_TEST=True python -m pytest -n 8 --integration --universal sdk/python/tests

Expand Down Expand Up @@ -198,4 +201,4 @@ build-sphinx: compile-protos-python
cd $(ROOT_DIR)/sdk/python/docs && $(MAKE) build-api-source

build-templates:
python infra/scripts/compile-templates.py
python infra/scripts/compile-templates.py
7 changes: 7 additions & 0 deletions docs/how-to-guides/adding-or-reusing-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,13 @@ The key fixtures are the `environment` and `universal_data_sources` fixtures, wh
* In `repo_configuration.py` add a new`IntegrationTestRepoConfig` or two (depending on how many online stores you want to test).
* Run the full test suite with `make test-python-integration.`

### Including a new offline / online store in the main Feast repo from external plugins with community maintainers.

* This folder is for plugins that are officially maintained with community owners. Place the APIs in feast/infra/offline_stores/contrib/.
* Extend `data_source_creator.py` for your offline store and implement the required APIs.
* In `contrib_repo_configuration.py` add a new `IntegrationTestRepoConfig` (depending on how many online stores you want to test).
* Run the test suite on the contrib test suite with `make test-python-contrib-universal`.

### To include a new online store

* In `repo_configuration.py` add a new config that maps to a serialized version of configuration you need in `feature_store.yaml` to setup the online store.
Expand Down
Empty file added sdk/python/feast/infra/offline_stores/contrib/__init__.py
View file
Open in desktop
Empty file.
10 changes: 10 additions & 0 deletions sdk/python/feast/infra/offline_stores/contrib/contrib_repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from tests.integration.feature_repos.integration_test_repo_config import (
IntegrationTestRepoConfig,
)
from tests.integration.feature_repos.universal.data_sources.spark_data_source_creator import (
SparkDataSourceCreator,
)

FULL_REPO_CONFIGS = [
IntegrationTestRepoConfig(offline_store_creator=SparkDataSourceCreator)
]