Skip to content

Remove old flag warning with the python feature server #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Feb 14, 2022
Merged

Remove old flag warning with the python feature server #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b233f0b
Remove outdated warnings around feast serve now that it's graduated f…
adchia Feb 10, 2022
b97dde8
fix lint
adchia Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ def init_command(project_directory, minimal: bool, template: str):
)
@click.pass_context
def serve_command(ctx: click.Context, host: str, port: int, no_access_log: bool):
"""[Experimental] Start a the feature consumption server locally on a given port."""
"""Start a feature server locally on a given port."""
repo = ctx.obj["CHDIR"]
cli_check_repo(repo)
store = FeatureStore(repo_path=str(repo))
Expand Down
6 changes: 0 additions & 6 deletions sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import traceback

import click
import uvicorn
from fastapi import FastAPI, HTTPException, Request
from fastapi.logger import logger
Expand Down Expand Up @@ -66,9 +65,4 @@ def start_server(
store: "feast.FeatureStore", host: str, port: int, no_access_log: bool
):
app = get_app(store)
click.echo(
"This is an "
+ click.style("experimental", fg="yellow", bold=True, underline=True)
+ " feature. It's intended for early testing and feedback, and could change without warnings in future releases."
)
uvicorn.run(app, host=host, port=port, access_log=(not no_access_log))