Skip to content

Compare only specs in integration tests#2200

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
felixwang9817:specs_only
Jan 7, 2022
Merged

Compare only specs in integration tests#2200
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
felixwang9817:specs_only

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented Jan 7, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: #1952 was recently merged and is currently breaking integration tests on master. Specifically, by setting created_timestamp for feature views, the test_universal_cli test breaks because the second feast apply changes FV metadata, causing the registry to be changed. This PR ensures that when registry contents are compared after the first and second calls to feast plan, only specs of the FCOs are compared, and metadata is excluded. This allows the test to pass.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817
Modify registry to_dict method to allow for returning only specs
349b769 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 requested a review from a team as a code owner January 7, 2022 07:01
@felixwang9817 felixwang9817 requested review from tsotnet and removed request for a team January 7, 2022 07:01
@felixwang9817 felixwang9817 requested review from achals and removed request for tsotnet January 7, 2022 07:01
achals
achals requested changes Jan 7, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the test to only compare the specs instead? Would be easier

@felixwang9817
Change test_cli test to keep only specs
4063d3d 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 changed the title Modify registry to_dict method to allow for returning only specs Compare only specs in integration tests Jan 7, 2022
@codecov-commenter

codecov-commenter commented Jan 7, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2200 (4063d3d) into master (ad3ea8d) will increase coverage by 25.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2200       +/-   ##
===========================================
+ Coverage   58.97%   84.62%   +25.65%     
===========================================
  Files         104      104               
  Lines        8270     8272        +2     
===========================================
+ Hits         4877     7000     +2123     
+ Misses       3393     1272     -2121
Flag Coverage Δ
integrationtests 74.38% <100.00%> (?)
unittests 58.95% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/tests/integration/registration/test_cli.py 100.00% <100.00%> (+40.83%) ⬆️
sdk/python/feast/data_source.py 61.29% <0.00%> (+0.40%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 87.82% <0.00%> (+0.86%) ⬆️
sdk/python/feast/online_response.py 87.71% <0.00%> (+1.75%) ⬆️
sdk/python/feast/feature.py 90.24% <0.00%> (+4.87%) ⬆️
sdk/python/feast/errors.py 71.11% <0.00%> (+5.18%) ⬆️
sdk/python/feast/infra/provider.py 90.09% <0.00%> (+5.40%) ⬆️
sdk/python/feast/infra/offline_stores/file.py 97.60% <0.00%> (+8.79%) ⬆️
sdk/python/feast/utils.py 100.00% <0.00%> (+10.00%) ⬆️
sdk/python/feast/infra/passthrough_provider.py 100.00% <0.00%> (+10.93%) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3ea8d...4063d3d. Read the comment docs.

achals
achals approved these changes Jan 7, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Jan 7, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 14048fd into feast-dev:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved kind/bug lgtm ok-to-test release-note-none size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @achals