Skip to content

Add romanwozniak to prow owners config#216

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
romanwozniak:add_roman_to_code_owners
Jun 17, 2019
Merged

Add romanwozniak to prow owners config#216
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
romanwozniak:add_roman_to_code_owners

Conversation

@romanwozniak

@romanwozniak romanwozniak commented Jun 17, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

@feast-ci-bot

feast-ci-bot commented Jun 17, 2019

Copy link
Copy Markdown
Collaborator

Hi @romanwozniak. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@romanwozniak

romanwozniak commented Jun 17, 2019

Copy link
Copy Markdown
Collaborator Author

/assign @davidheryanto
/assign @budi

@budi

budi commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

/lgtm
welcome~

@davidheryanto

davidheryanto commented Jun 17, 2019

Copy link
Copy Markdown
Collaborator

/approve

@feast-ci-bot

feast-ci-bot commented Jun 17, 2019

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto, romanwozniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 4e2b295 into feast-dev:master Jun 17, 2019
@romanwozniak romanwozniak deleted the add_roman_to_code_owners branch June 17, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto

@pradithya pradithya Awaiting requested review from pradithya

@thirteen37 thirteen37 Awaiting requested review from thirteen37

@tims tims Awaiting requested review from tims

@woop woop Awaiting requested review from woop

@zhilingc zhilingc Awaiting requested review from zhilingc

Assignees

@budi budi

@davidheryanto davidheryanto

Labels

approved lgtm needs-ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@romanwozniak @feast-ci-bot @budi @davidheryanto