Add DatastoreTable infra object#2140
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
===========================================
+ Coverage 57.88% 82.66% +24.77%
===========================================
Files 101 102 +1
Lines 8176 9501 +1325
===========================================
+ Hits 4733 7854 +3121
+ Misses 3443 1647 -1796
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| oneof project_id { | ||
| bool project_id_null = 3; | ||
| string project_id_value = 4; | ||
| } | ||
|
|
||
| // Datastore namespace, which can be null | ||
| oneof namespace { | ||
| bool namespace_null = 5; | ||
| string namespace_value = 6; | ||
| } |
There was a problem hiding this comment.
These should probably be google.protobuf.StringValue. That's a struct type, that can be null - so you don't have to implement the same wrapper here and can reuse StringValue instead.
| ) | ||
|
|
||
| def update(self): | ||
| client = _initialize_client(self.project_id, self.namespace) |
There was a problem hiding this comment.
any reason this can't be initialized in __init__?
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: This PR adds an
InfraObjectfor Datastore tables, as part of thefeast planimplementation.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: