Skip to content

Have apply_total use the repo_config that's passed in as a parameter (makes it more compatible with custom wrapper code) - #2099

Merged
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
mavysavydav:repoOperationsUpdate
Dec 2, 2021
Merged

Have apply_total use the repo_config that's passed in as a parameter (makes it more compatible with custom wrapper code)#2099
feast-ci-bot merged 2 commits into
feast-dev:masterfrom
mavysavydav:repoOperationsUpdate

Conversation

@mavysavydav

Copy link
Copy Markdown
Collaborator

Signed-off-by: David Y Liu davidyliuliu@gmail.com

Have apply_total use the repo_config that's passed in as a parameter rather than re-producing the repo config from the repo path. 

Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
Comment thread sdk/python/feast/repo_operations.py Outdated
Co-authored-by: Achal Shah <achals@gmail.com>
@mavysavydav

Copy link
Copy Markdown
Collaborator Author

/ok-to-test

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, mavysavydav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817,mavysavydav]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit fc9b767 into feast-dev:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants