Add --host as an option for feast serve#2078
Conversation
Today the value is hardcoded to 127.0.0.1. This will enable uses to specify the host that they want to use for feast serve. Signed-off-by: Gunnar Sv Sigurbjörnsson <gunnar.sigurbjornsson@gmail.com>
nossrannug
requested review from
a team,
achals,
adchia,
felixwang9817,
tsotnet and
woop
as code owners
|
Hi @nossrannug. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #2078 +/- ##
==========================================
+ Coverage 83.32% 83.33% +0.01%
==========================================
Files 100 100
Lines 8084 8085 +1
==========================================
+ Hits 6736 6738 +2
+ Misses 1348 1347 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, nossrannug The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Signed-off-by: Gunnar Sv Sigurbjörnsson gunnar.sigurbjornsson@gmail.com
What this PR does / why we need it:
Today the value is hardcoded to 127.0.0.1. This will enable users to
specify the host that they want to use for feast serve.
Does this PR introduce a user-facing change?: