Skip to content

Add Feast CLI / python SDK documentation#199

Merged
feast-ci-bot merged 21 commits into
feast-dev:masterfrom
romanwozniak:end-user-quickstart
May 28, 2019
Merged

Add Feast CLI / python SDK documentation#199
feast-ci-bot merged 21 commits into
feast-dev:masterfrom
romanwozniak:end-user-quickstart

Conversation

@romanwozniak

Copy link
Copy Markdown
Collaborator

In this PR:

  • Removed all mentions of granularity from the documentation / proto (because it was removed from the codebase in Remove feature "granularity" and relegate to metadata #17)
  • Picked up some WIP Feast CLI docs from @thirteen37 and updated them with information about import job spec registration
  • Added a quick start guide for feast python SDK (how to install it, register entity/features, ingest features into feast, retrieve training/serving data)

thirteen37 and others added 13 commits May 2, 2019 18:13
Using vendored protobuf, here are the new generated files
# Conflicts:
#	charts/feast/values.yaml
#	docs/install.md
#	protos/generated/go/feast/core/CoreService.pb.go
#	protos/generated/go/feast/core/DatasetService.pb.go
#	protos/generated/go/feast/core/JobService.pb.go
#	protos/generated/go/feast/core/UIService.pb.go
#	protos/generated/go/feast/serving/Serving.pb.go
#	protos/generated/go/feast/specs/EntitySpec.pb.go
#	protos/generated/go/feast/specs/FeatureGroupSpec.pb.go
#	protos/generated/go/feast/specs/FeatureSpec.pb.go
#	protos/generated/go/feast/specs/ImportJobSpecs.pb.go
#	protos/generated/go/feast/specs/ImportSpec.pb.go
#	protos/generated/go/feast/specs/StorageSpec.pb.go
#	protos/generated/go/feast/storage/BigTable.pb.go
#	protos/generated/go/feast/storage/Redis.pb.go
#	protos/generated/go/feast/types/Feature.pb.go
#	protos/generated/go/feast/types/FeatureRow.pb.go
#	protos/generated/go/feast/types/FeatureRowExtended.pb.go
#	protos/generated/go/feast/types/Value.pb.go
@feast-ci-bot

Copy link
Copy Markdown
Collaborator

Hi @romanwozniak. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pradithya

Copy link
Copy Markdown
Collaborator

/ok-to-test

Comment thread docs/specs.md Outdated
Comment thread examples/values.yaml
Use Feast image tag 0.1.1 because it fixes some templating in BigQuery
https://github.com/gojek/feast/releases/tag/v0.1.1
@zhilingc

Copy link
Copy Markdown
Collaborator

/lgtm

Thanks Roman!

@feast-ci-bot feast-ci-bot removed the lgtm label May 27, 2019
@davidheryanto

Copy link
Copy Markdown
Collaborator

/lgtm

@zhilingc

Copy link
Copy Markdown
Collaborator

/approve

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: romanwozniak, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 1bdbfb5 into feast-dev:master May 28, 2019
@romanwozniak romanwozniak deleted the end-user-quickstart branch May 28, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants