Skip to content

Feature transformation server docker image#1972

Merged
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
felixwang9817:fts_docker_image
Oct 26, 2021
Merged

Feature transformation server docker image#1972
feast-ci-bot merged 2 commits intofeast-dev:masterfrom
felixwang9817:fts_docker_image

Conversation

@felixwang9817
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 commented Oct 26, 2021

What this PR does / why we need it: This PR builds a Docker image for the Python FTS.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@felixwang9817
Add Dockerfile and app for building FTS docker image
35c8127 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Add CI for building FTS
fd19922 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817 felixwang9817 requested review from a team, achals, adchia, tsotnet and woop as code owners October 26, 2021 03:12
@felixwang9817
Copy link
Copy Markdown
Collaborator Author

felixwang9817 commented Oct 26, 2021

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 26, 2021
@felixwang9817 felixwang9817 changed the title Fts docker image Feature transformation server docker image Oct 26, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 26, 2021 •
edited
Loading

Codecov Report

Merging #1972 (fd19922) into master (3768766) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1972   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files         100      100           
  Lines        7987     7991    +4     
=======================================
+ Hits         6555     6559    +4     
  Misses       1432     1432
Flag Coverage Δ
integrationtests 74.47% <100.00%> (+0.01%) ⬆️
unittests 59.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 38.70% <100.00%> (+0.19%) ⬆️
sdk/python/feast/constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3768766...fd19922. Read the comment docs.

adchia
adchia requested changes Oct 26, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 252ca47 into feast-dev:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

@achals achals Awaiting requested review from achals

@tsotnet tsotnet Awaiting requested review from tsotnet

@woop woop Awaiting requested review from woop

Assignees

@adchia adchia

Labels

approved kind/feature New feature or request lgtm release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @adchia