Skip to content

Create the BQ dataset in the location specified in feature_store.yaml if the dataset doesn't exists #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 4 commits into from
Nov 18, 2021
Merged

Create the BQ dataset in the location specified in feature_store.yaml if the dataset doesn't exists #1959

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a26d0e0
fixes #1958
francoisserra Oct 21, 2021
67e23bc
Fix lint
achals Nov 18, 2021
b199e77
Fix lint
achals Nov 18, 2021
dfa591a
merge from master
achals Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sdk/python/feast/infra/offline_stores/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ def get_historical_features(
assert isinstance(config.offline_store, BigQueryOfflineStoreConfig)

table_reference = _get_table_reference_for_new_entity(
client, client.project, config.offline_store.dataset
client,
client.project,
config.offline_store.dataset,
config.offline_store.location,
)

@contextlib.contextmanager
Expand Down Expand Up @@ -340,13 +343,16 @@ def _wait_until_done(bq_job):


def _get_table_reference_for_new_entity(
client: Client, dataset_project: str, dataset_name: str
client: Client,
dataset_project: str,
dataset_name: str,
dataset_location: Optional[str],
) -> str:
"""Gets the table_id for the new entity to be uploaded."""

# First create the BigQuery dataset if it doesn't exist
dataset = bigquery.Dataset(f"{dataset_project}.{dataset_name}")
dataset.location = "US"
dataset.location = dataset_location if dataset_location else "US"

try:
client.get_dataset(dataset)
Expand Down