Skip to content

Fix conditional statements for if OnDemandFVs exist - #1937

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
codyjlin:to_bigquery-bugfix
Oct 14, 2021
Merged

Fix conditional statements for if OnDemandFVs exist#1937
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
codyjlin:to_bigquery-bugfix

Conversation

@codyjlin

@codyjlin codyjlin commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Cody Lin codyl@twitter.com

What this PR does / why we need it:
There's an inconsistency for checking whether there are self.on_demand_feature_views - if this value is an empty list [] as returned by on_demand_feature_view.get_requested_odfvs (like here), then the old conditional statements are wrong.

Which issue(s) this PR fixes:

Small bugfix, no issue

Does this PR introduce a user-facing change?:

NONE

Cody Lin
Fix conditional statements for if OnDemandFVs exist
4a931ec 
Signed-off-by: Cody Lin <codyl@twitter.com>
@feast-ci-bot

feast-ci-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

Hi @codyjlin. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyjlin

codyjlin commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

/kind bug

@codecov-commenter

codecov-commenter commented Oct 14, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1937 (4a931ec) into master (156d004) will decrease coverage by 22.88%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1937       +/-   ##
===========================================
- Coverage   82.27%   59.39%   -22.89%     
===========================================
  Files          96       96               
  Lines        7669     7669               
===========================================
- Hits         6310     4555     -1755     
- Misses       1359     3114     +1755
Flag Coverage Δ
integrationtests ?
unittests 59.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 30.38% <0.00%> (-49.73%) ⬇️
sdk/python/feast/infra/offline_stores/redshift.py 36.66% <0.00%> (-48.34%) ⬇️
.../integration/online_store/test_universal_online.py 13.74% <0.00%> (-85.50%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
...fline_store/test_universal_historical_retrieval.py 17.14% <0.00%> (-82.15%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 18.18% <0.00%> (-81.82%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...s/integration/registration/test_universal_types.py 35.41% <0.00%> (-64.59%) ⬇️
...istration/test_universal_odfv_feature_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156d004...4a931ec. Read the comment docs.

@mavysavydav

mavysavydav commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

/lgtm

@feast-ci-bot

feast-ci-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

@mavysavydav: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adchia
adchia approved these changes Oct 14, 2021
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Oct 14, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, codyjlin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit e8a1519 into feast-dev:master Oct 14, 2021
@codyjlin
codyjlin deleted the to_bigquery-bugfix branch October 14, 2021 03:42
felixwang9817 pushed a commit that referenced this pull request Oct 28, 2021
@codyjlin @felixwang9817
Fix conditional statements for if OnDemandFVs exist (#1937)
2711e53 
Signed-off-by: Cody Lin <codyl@twitter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes
@achals achals Awaiting requested review from achals
@felixwang9817 felixwang9817 Awaiting requested review from felixwang9817
@tsotnet tsotnet Awaiting requested review from tsotnet
@woop woop Awaiting requested review from woop

Assignees

@adchia adchia

Labels

approved kind/bug lgtm needs-ok-to-test release-note-none size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codyjlin @feast-ci-bot @codecov-commenter @mavysavydav @adchia