Support adding request data in on demand transforms#1851
Conversation
achals
left a comment
achals
left a comment
There was a problem hiding this comment.
Nice! I think we should add some tests to assert proper handling of the error cases, but looks good otherwise.
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
adchia
force-pushed
the
request_data
branch
from
2f4cb54 to
ecdb1f4
Compare
Signed-off-by: Danny Chiao <danny@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #1851 +/- ##
==========================================
+ Coverage 84.87% 85.08% +0.21%
==========================================
Files 91 91
Lines 6961 7089 +128
==========================================
+ Hits 5908 6032 +124
- Misses 1053 1057 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
| @staticmethod | ||
| def source_datatype_to_feast_value_type() -> Callable[[str], ValueType]: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
nit: I wonder if this method makes sense for this type of data source. We should probably refactor the DataSource interface to make it simpler and introduce a BatchDataSource somewhere in the type hierarchy.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
What this PR does / why we need it:
Supports adding request data as a dependency in on demand transforms. This validates when if the entity_df or entity_rows don't have the required request data features.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: