Clean up uploaded entities in Redshift offline store#1730
Merged
feast-ci-bot merged 2 commits intoJul 28, 2021
Conversation
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
==========================================
- Coverage 79.08% 79.02% -0.06%
==========================================
Files 80 80
Lines 6855 6895 +40
==========================================
+ Hits 5421 5449 +28
- Misses 1434 1446 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
woop
reviewed
Jul 23, 2021
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tsotnet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tsotne Tabidze tsotne@tecton.ai
What this PR does / why we need it: Currently uploaded Redshift entities are not cleaned up. They're left as random tables in Redshift. With this PR, the entities will not be uploaded during get_historical_features, but when you call to_X (e.g. to_df) on the returned RetrievalJob. At the same time, we'll clean up the uploaded entity table at the end of to_X call.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: