Skip to content

Redirect telemetry to usage - #1717

Merged
woop merged 1 commit into
feast-dev:masterfrom
felixwang9817:telemetry_redirect
Jul 16, 2021
Merged

Redirect telemetry to usage#1717
woop merged 1 commit into
feast-dev:masterfrom
felixwang9817:telemetry_redirect

Conversation

@felixwang9817

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it: Previous, Feast docs used the following link: https://docs.feast.dev/reference/telemetry. Since we have started using 'usage' instead of 'telemetry', the link no longer works, so we set up a redirect to https://docs.feast.dev/reference/telemetry.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@codecov-commenter

codecov-commenter commented Jul 16, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1717 (05429cf) into master (5e89ccf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1717   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          79       79           
  Lines        7012     7012           
=======================================
  Hits         5922     5922           
  Misses       1090     1090           
Flag Coverage Δ
integrationtests 84.38% <ø> (ø)
unittests 69.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e89ccf...05429cf. Read the comment docs.

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
woop merged commit c5300cb into feast-dev:master Jul 16, 2021
@felixwang9817
felixwang9817 deleted the telemetry_redirect branch July 17, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants