Skip to content

Add a specific error for missing columns during materialization - #1619

Merged
woop merged 5 commits into
feast-dev:masterfrom
achals:achal/file-validation-test
Jun 11, 2021
Merged

Add a specific error for missing columns during materialization#1619
woop merged 5 commits into
feast-dev:masterfrom
achals:achal/file-validation-test

Conversation

@achals

@achals achals commented Jun 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
Follow up from #1615 based on the comment in #1614 . Also adds test and removed an empty file.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@achals
achals requested review from a team, jklegar, tsotnet and woop as code owners June 3, 2021 20:33
@codecov-commenter

codecov-commenter commented Jun 3, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1619 (2ff2504) into master (008a9ea) will increase coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   77.61%   77.63%   +0.02%     
==========================================
  Files          66       66              
  Lines        5789     5799      +10     
==========================================
+ Hits         4493     4502       +9     
- Misses       1296     1297       +1
Flag Coverage Δ
unittests 77.63% <81.81%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/file.py 96.70% <50.00%> (+0.03%) ⬆️
sdk/python/feast/errors.py 64.28% <75.00%> (+1.12%) ⬆️
sdk/python/tests/test_e2e_local.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008a9ea...2ff2504. Read the comment docs.

woop
woop reviewed Jun 7, 2021
View reviewed changes
Comment thread sdk/python/feast/errors.py Outdated
@achals
achals force-pushed the achal/file-validation-test branch from 8db43cb to 26c4aa6 Compare June 7, 2021 18:52
@feast-ci-bot

feast-ci-bot commented Jun 7, 2021

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
achals force-pushed the achal/file-validation-test branch 3 times, most recently from 859c842 to 751eeb1 Compare June 9, 2021 18:51
achals added 5 commits June 9, 2021 12:11
@achals
Add a specific error for missing columns during materialization
c26d973 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
make format
65d65e3 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Be more specific about dataframe
0ee858d 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
Update error message
41136c8 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
format
44b07eb 
Signed-off-by: Achal Shah <achals@gmail.com>
@achals
achals force-pushed the achal/file-validation-test branch from 2ff2504 to 44b07eb Compare June 9, 2021 19:11
@achals

achals commented Jun 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@woop ready for re-review

@woop

woop commented Jun 9, 2021

Copy link
Copy Markdown
Member

/lgtm

@achals
achals requested a review from woop June 9, 2021 23:38
@achals

achals commented Jun 11, 2021

Copy link
Copy Markdown
Member Author

@woop for some reason this didn't get auto-merged - can you approve if it looks okay?

@woop
woop merged commit 1fd030c into feast-dev:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklegar jklegar Awaiting requested review from jklegar
@tsotnet tsotnet Awaiting requested review from tsotnet
@woop woop Awaiting requested review from woop

Assignees

@woop woop

Labels

approved kind/housekeeping lgtm release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @codecov-commenter @feast-ci-bot @woop